Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )
Change subject: drivers/wifi: Add generic WiFi driver ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/#/c/33155/3/src/drivers/intel/wifi/Kconfig File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/33155/3/src/drivers/intel/wifi/Kconfig@3 PS3, Line 3: depends on ARCH_X86
I will upload a follow-up patch on that one.
Done
https://review.coreboot.org/#/c/33155/3/src/drivers/intel/wifi/wifi.c File src/drivers/intel/wifi/wifi.c:
https://review.coreboot.org/#/c/33155/3/src/drivers/intel/wifi/wifi.c@68 PS3, Line 68: struct drivers_intel_wifi_config *config = dev->chip_info;
Ok.
Done
https://review.coreboot.org/#/c/33155/3/src/drivers/intel/wifi/wifi.c@73 PS3, Line 73: generic_wifi_fill_ssdt(dev, &generic_config);
Ok.
Done
https://review.coreboot.org/#/c/33155/3/src/drivers/wifi/Kconfig File src/drivers/wifi/Kconfig:
https://review.coreboot.org/#/c/33155/3/src/drivers/wifi/Kconfig@9 PS3, Line 9: config USE_SAR
Ok.
Done
https://review.coreboot.org/#/c/33155/3/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/#/c/33155/3/src/drivers/wifi/generic.c@174 PS3, Line 174: if (!path || !dev->enabled)
Ok.
Added the check here so that we don't have to add it redundantly every place where this function is invoked.
https://review.coreboot.org/#/c/33155/3/src/drivers/wifi/generic.c@191 PS3, Line 191: if (config && config->wake)
Ok.
Done