Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43332 )
Change subject: soc/amd/picasso: Add support for DRIVERS_USB_PCI_XHCI
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43332/1/src/soc/amd/picasso/xhci.c
File src/soc/amd/picasso/xhci.c:
https://review.coreboot.org/c/coreboot/+/43332/1/src/soc/amd/picasso/xhci.c@...
PS1, Line 15: mainboard_get_gpe_table
In my opinion, it is totally fine to keep(hard code) this within the soc/ rather than having mainboa […]
Done
This feels a lot cleaner and encapsulated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice7203831a1f65ed32f3a6392fe02c4b17d42617
Gerrit-Change-Number: 43332
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jul 2020 21:22:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment