Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35891 )
Change subject: sb/amd/{agesa,pi}/hudson/Kconfig: Change default SATA mode to AHCI
......................................................................
Patch Set 4: Code-Review+1
SeaBIOS (and Grub) use PIO instead of DMA with IDE mode, so AHCI is indeed a better default IMO. The speed difference is easily a order of magnitude faster with AHCI (on ICH7 at least).
IIRC SeaBIOS needs explicit:
CONFIG_ATA_DMA=y
CONFIG_ATA_PIO32=y
passed as a SeaBIOS config file in order to use PIO. Maybe should I add a patch for default PIO in SeaBIOS Makefile?
AFAIK, it's not the default because it breaks compatibility
with actual PATA drives. So it would have to be decided per
board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b0322392712d797dd5a8931150c8d0ff1b60940
Gerrit-Change-Number: 35891
Gerrit-PatchSet: 4
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Feb 2020 11:36:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment