7 May
2019
7 May
'19
3:56 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32069 )
Change subject: nb/intel/sandybridge: Migrate MRC settings to devicetree ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/#/c/32069/9/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/#/c/32069/9/src/northbridge/intel/sandybridge/ra... PS9, Line 385: pei_data.dimm_channel0_disabled = this might not work on lumpy as the onboard spd config looks fishy. It uses spd_data[0] which should be spd_data[2] IMHO.
--
To view, visit https://review.coreboot.org/c/coreboot/+/32069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d9f0fd6a2b792ac693d6016ed9ce44945c900c
Gerrit-Change-Number: 32069
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jan Tatje jan@jnt.io
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nico Rikken nico@nicorikken.eu
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 13:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment