Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48246 )
Change subject: soc/intel/common/block/acpi: Allow additional soc overrides
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48246/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/48246/4/src/soc/intel/common/block/...
PS4, Line 85: __weak unsigned long acpi_fill_madt(unsigned long current)
As usual, I would prefer not to have a weak function with actual content.
In the past this has led to confusion and bugs.
What is it that the new implementation would make differently? Could it
be handled by a Kconfig switch maybe?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic818a634e4912d88ef93971deb4da5ab708c9020
Gerrit-Change-Number: 48246
Gerrit-PatchSet: 4
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 08 Dec 2020 21:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment