build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )
Change subject: soc/intel/cannonlake: Dump ME f/w version and status information. ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@28 PS1, Line 28: { open brace '{' following enum go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@39 PS1, Line 39: { open brace '{' following enum go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@50 PS1, Line 50: { open brace '{' following union go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@75 PS1, Line 75: { open brace '{' following union go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@100 PS1, Line 100: { open brace '{' following union go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@106 PS1, Line 106: { open brace '{' following union go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@123 PS1, Line 123: { open brace '{' following union go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@143 PS1, Line 143: { open brace '{' following union go on the same line
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@267 PS1, Line 267: printk(BIOS_DEBUG, "ME: HFSTS1 : 0x%08X\n", hfsts1.raw); line over 80 characters
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@268 PS1, Line 268: printk(BIOS_DEBUG, "ME: HFSTS2 : 0x%08X\n", hfsts2.raw); line over 80 characters
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@269 PS1, Line 269: printk(BIOS_DEBUG, "ME: HFSTS3 : 0x%08X\n", hfsts3.raw); line over 80 characters
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@270 PS1, Line 270: printk(BIOS_DEBUG, "ME: HFSTS4 : 0x%08X\n", hfsts4.raw); line over 80 characters
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@271 PS1, Line 271: printk(BIOS_DEBUG, "ME: HFSTS5 : 0x%08X\n", hfsts5.raw); line over 80 characters
https://review.coreboot.org/#/c/32527/1/src/soc/intel/cannonlake/me.c@272 PS1, Line 272: printk(BIOS_DEBUG, "ME: HFSTS6 : 0x%08X\n", hfsts6.raw); line over 80 characters