[coreboot-gerrit] Change in coreboot[master]: soc/intel: Allow enable/disable ME via CMOS

[Sean Rhodes (Code Review)]

Attention is currently required from:  Felix Singer, SRIDHAR SIRICILLA, Furquan Shaikh, Paul Menzel, Rizwan Qureshi, Tim Wawrzynczak, Subrata Banik, Sridhar Siricilla, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph, Felix Held.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )

Change subject: soc/intel: Allow enable/disable ME via CMOS
......................................................................

Patch Set 91:

(3 comments)

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/52800/comment/2b9cad10_34c7c03e 
PS88, Line 1067: me_state
> That alright?

Done

https://review.coreboot.org/c/coreboot/+/52800/comment/23a54c73_a5a6ae3a 
PS88, Line 1085: enable
> Slightly inefficient but clear, cool?

Done

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/52800/comment/488b6b1f_06428fab 
PS90, Line 991: /* (CS)ME Disable Command */
              : struct me_disable_command {
              : 	struct mkhi_hdr hdr;
              : 	uint32_t rule_id;
              : 	uint8_t rule_len;
              : 	uint32_t rule_data;
              : } __packed me_disable = {
              : 	.hdr = {
              : 		.group_id = MKHI_GROUP_ID_FWCAPS,
              : 		.command = MKHI_SET_ME_DISABLE,
              : 	},
              : 	.rule_id = ME_DISABLE_RULE_ID,
              : 	.rule_len = ME_DISABLE_RULE_LENGTH,
              : 	.rule_data = ME_DISABLE_COMMAND,
              : };
              : 
              : struct me_disable_reply {
              : 	struct mkhi_hdr hdr;
              : 	uint32_t rule_id;
              : } __packed;
              : 
              : struct me_disable_reply disable_reply;
              : 
              : size_t disable_reply_size;
              : 
              : /* (CS)ME Enable Command */
              : struct me_enable_command {
              : 	struct mkhi_hdr hdr;
              : } me_enable = {
              : 	.hdr = {
              : 		.group_id = MKHI_GROUP_ID_BUP_COMMON,
              : 		.command = MKHI_SET_ME_ENABLE,
              : 	},
              : };
              : 
              : struct me_enable_reply {
              : 	struct mkhi_hdr hdr;
              : } __packed;
              : 
              : struct me_enable_reply enable_reply;
              : 
              : size_t enable_reply_size;
> Is that okay?

Done