[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD CnviWifiCore

[Subrata Banik (Code Review)]

Attention is currently required from: Tarun Tuli, Kapil Porwal, Paul Menzel, Eric Lai.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74306 )

Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/meteorlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/74306/comment/fed052d9_852902d7 
PS3, Line 565: s_cfg->CnviWifiCore = config->cnvi_wifi_core;
> `CnviMode` is a master option so setting `CnviWifiCore` to 1/0 does not make any difference when `CnviMode` is 0.
> Here assert() is helping to catch potential misconfiguration.

that's true. how about a non-serial image where assert lib would replaced by NULL. then how can we catch such misconfiguration is my question?

Also, answering @eric's question, yes, ideally we should club all relevant UPDs (wifi, bt core and bt offline)