build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52861 )
Change subject: x86/exception: Print the offset within the stage that caused the fault ......................................................................
Patch Set 1:
(2 comments)
File src/arch/x86/exception.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118262): https://review.coreboot.org/c/coreboot/+/52861/comment/786e55d7_5ddcc563 PS1, Line 381: if ((uintptr_t)_program <= IP && (uintptr_t)_eprogram > IP ) space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118262): https://review.coreboot.org/c/coreboot/+/52861/comment/e53e0da9_8d826e7d PS1, Line 383: "Faulty instruction is in " ENV_STRING " at offset 0x%zx\n", IP - (uintptr_t)_program); line over 96 characters