3 Apr
2023
3 Apr
'23
6:37 p.m.
Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74108 )
Change subject: mb/google/myst: Add initial I2C configuration ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/myst/variants/myst/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74108/comment/94d582eb_27c76b92 PS5, Line 33: # I2C Config
For skyrim, these live in `baseboard/devicetree.cb`. Is moving them here into `overridetree. […]
On Skyrim they started here I think and got moved later. I'm fine putting them in the baseboard devicetree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74108
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44668295fb6ed03992df9d9fc075792e181d1a8a
Gerrit-Change-Number: 74108
Gerrit-PatchSet: 6
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 18:37:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment