Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41385 )
Change subject: soc/intel/tigerlake: Move PMC PCI resources under PMC device
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41385/7/src/soc/intel/tigerlake/pmc...
File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/41385/7/src/soc/intel/tigerlake/pmc...
PS7, Line 78: static void pmc_init(struct device *dev)
The timing will be different when this is called. BS_DEV_INIT_CHIPS vs BS_DEV_INIT. You may want this toe be the enable() call in device_operations to make it earlier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7c6ae849aefaf549fb682416a87320907fb3fe3
Gerrit-Change-Number: 41385
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 May 2020 20:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment