Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )
Change subject: soc/intel/common/systemagent: Add SOC_INTEL_COMMON_BLOCK_SA_VERSION_2 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38456/2/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/38456/2/src/soc/intel/common/block/... PS2, Line 49: #endif
Can’t this be detected at run-time, and the table be created at run-time?
this is EDS register changes hence their is not way to detect using runtime.
Also i was referring to GSPI version 2 made by Furquan for similar reason during CNL
https://review.coreboot.org/c/coreboot/+/38456/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/38456/2/src/soc/intel/common/block/... PS2, Line 44: (unsigned long)
Why is this needed?
4096 * MiB = 0x100000000 (which is > 32bit) hence Case is treating this as 0 (type casted as int), ignoring > 32bit (bit 33)
Also compilation error https://qa.coreboot.org/job/coreboot-gerrit/114754/testReport/junit/board/ch...