Attention is currently required from: Jamie Chen, Stanley Wu, Marco Chen, Eric Lai.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 )
Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku() ......................................................................
Patch Set 3:
(15 comments)
File src/mainboard/google/octopus/variants/phaser/memory.c:
https://review.coreboot.org/c/coreboot/+/69925/comment/a35d03a0_aa373c2d PS1, Line 24: size_t rt;
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/4251e97c_119759ac PS1, Line 24: size_t rt;
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/033723bd_b0930499 PS1, Line 25: gpio_t pads[] = {
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/7a8f9f99_9d7f8053 PS1, Line 25: gpio_t pads[] = {
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/588b30e3_0554b649 PS1, Line 26: [3] = MEM_CONFIG3, [2] = MEM_CONFIG2,
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/00e62912_002602bc PS1, Line 26: [3] = MEM_CONFIG3, [2] = MEM_CONFIG2,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/ed71b679_5877c8fe PS1, Line 27: [1] = MEM_CONFIG1, [0] = MEM_CONFIG0,
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/437a95fd_ffb8106c PS1, Line 27: [1] = MEM_CONFIG1, [0] = MEM_CONFIG0,
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/bdf2ef2f_ebdab6dd PS1, Line 28: };
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/53befa8d_c4f42dd6 PS1, Line 28: };
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/c205fa1f_f9fbb725 PS1, Line 30: rt = gpio_base2_value(pads, ARRAY_SIZE(pads));
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/4132ceb0_8ed5cc60 PS1, Line 30: rt = gpio_base2_value(pads, ARRAY_SIZE(pads));
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/59a42f80_e9ef495e PS1, Line 31: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/db34849d_135ce7c2 PS1, Line 31: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/69925/comment/5264e527_bf176841 PS1, Line 32: }
adding a line without newline at end of file
Please fix.