Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37604 )
Change subject: soc/intel/cannonlake: [TEST-ONLY] Enable Audio DSP OSC qualification for low power idle ......................................................................
Patch Set 2:
(3 comments)
Patch Set 2:
Furquan, this needs to go in the qualified image....
https://review.coreboot.org/c/coreboot/+/37604/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37604/2//COMMIT_MSG@7 PS2, Line 7: Enable Audio DSP OSC qualification for low power idle Can you please update the commit message to reflect why this change is required? Or what problem is it attempting to solve?
https://review.coreboot.org/c/coreboot/+/37604/2//COMMIT_MSG@8 PS2, Line 8: BUG=?
https://review.coreboot.org/c/coreboot/+/37604/2/src/soc/intel/cannonlake/fi... File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/37604/2/src/soc/intel/cannonlake/fi... PS2, Line 101: Enable Audio DSP OSC qualification for low power idle. Does this break runtime S0ix?