Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
ot_song fan has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85841?usp=email )
Change subject: soc/mediatek/mt8196: Add clk_buf drivers ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85841/comment/8d6ba8d4_25a6a2f7?usp... : PS4, Line 9: use
uses
Done
File src/soc/mediatek/mt8196/clkbuf_ctl.c:
https://review.coreboot.org/c/coreboot/+/85841/comment/8dcc8c0e_6dff9392?usp... : PS4, Line 27: /* Porting starting from here */
What does this mean? Can we remove the comment?
Done
https://review.coreboot.org/c/coreboot/+/85841/comment/5729a521_305f6356?usp... : PS4, Line 156: }
Add `,`
Done
https://review.coreboot.org/c/coreboot/+/85841/comment/ecea8c76_27faf35a?usp... : PS4, Line 347: = 0
remove
Done
https://review.coreboot.org/c/coreboot/+/85841/comment/663484c4_61878e53?usp... : PS4, Line 354: __func__, sel, val);
Move to previous line.
Done