Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40141 )
Change subject: Kill the dead_code macro
......................................................................
Patch Set 5: Code-Review-1
Uhh... context? I rather like my macro and would prefer to keep it unless there are real issues with it that cannot be solved otherwise. Can you explain how it "broke master quite spectacularly"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06f825e045d3305dd8ab81311fd2d003d03ae43a
Gerrit-Change-Number: 40141
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Apr 2020 20:05:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment