[coreboot-gerrit] [XS] Change in coreboot[main]: payloads/external/Makefile.mk: Update linuxboot warning

[Elyes Haouas (Code Review)]

Attention is currently required from: Martin L Roth, Maximilian Brune.

Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85957?usp=email )

Change subject: payloads/external/Makefile.mk: Update linuxboot warning
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
- Use of strip:
If the variable contains only whitespace (e.g., " "), ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH),"") would not catch it, but ifeq ($(strip $(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH)),) would.

- use of ":="  is for immediate evaluation

what's about :
"ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE),y)
    ifeq ($(strip $(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH)),)
        # No custom toolchain specified, use coreboot's cross toolchain
        CONFIG_LINUXBOOT_CROSS_COMPILE_PATH := $(CROSS_COMPILE_$(LINUXBOOT_CROSS_COMPILE_ARCH-y))
    endif
else
    ifeq ($(CONFIG_PAYLOAD_LINUXBOOT),y)
        # Print a warning that we are using the host toolchain
        $(warning "Using host toolchain to build LinuxBoot")
    endif
endif
" ?