[coreboot-gerrit] Change in coreboot[master]: [RFC] AMD APM_CNT and SMI enablement

[Felix Held (Code Review)]

Attention is currently required from: Marshall Dawson, Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42563 )

Change subject: [RFC] AMD APM_CNT and SMI enablement
......................................................................

Patch Set 1:

(1 comment)

File src/soc/amd/picasso/southbridge.c:

https://review.coreboot.org/c/coreboot/+/42563/comment/f88ca5b7_83eb29e1 
PS1, Line 244: 	pm_write16(PM_GPE0_BLK, ACPI_GPE0_BLK);
> without having looked into that, this sounds like a bug to me

from a quick look i'd say that it's not a bug, since the mmio mapping is used there and not the legacy io mapping that gets set up here. i'll try to have a closer look soon