[coreboot-gerrit] Change in coreboot[master]: src/drivers/i2c/rx6110sa: Omit _HID temporarily

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47706 )

Change subject: src/drivers/i2c/rx6110sa: Omit _HID temporarily
......................................................................

src/drivers/i2c/rx6110sa: Omit _HID temporarily

The current HID "RX6110SA" does not comply with the ACPI spec in terms
of the naming convention where the first three caracters should be a
vendor ID and the last 4 characters should be a device ID. For now
there is a vendor ID for Epson (SEC) but there is none for this
particular RTC. In order to avoid the reporting of a non ACPI-compliant
HID it will be dropped completely for now.

Once Epson has assigned a valid HID for this RTC, this valid HID will be
used here instead.

Change-Id: Ib77ffad084c25f60f79ec7d503f14731b1ebe9e2
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47706
Reviewed-by: Nico Huber 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/drivers/i2c/rx6110sa/rx6110sa.c
M src/drivers/i2c/rx6110sa/rx6110sa.h
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.c b/src/drivers/i2c/rx6110sa/rx6110sa.c
index 2b8b9b2..210444e 100644
--- a/src/drivers/i2c/rx6110sa/rx6110sa.c
+++ b/src/drivers/i2c/rx6110sa/rx6110sa.c
@@ -198,7 +198,6 @@
    /* Device */
    acpigen_write_scope(scope);
    acpigen_write_device(acpi_device_name(dev));
-	acpigen_write_name_string("_HID", RX6110SA_HID_NAME);
    acpigen_write_name_string("_DDN", RX6110SA_HID_DESC);
    acpigen_write_STA(acpi_device_status(dev));

diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h
index 557a748..fc0109d 100644
--- a/src/drivers/i2c/rx6110sa/rx6110sa.h
+++ b/src/drivers/i2c/rx6110sa/rx6110sa.h
@@ -4,7 +4,6 @@
 #define _I2C_RX6110SA_H_

#define RX6110SA_ACPI_NAME		"ERX6"
-#define RX6110SA_HID_NAME		"RX6110SA"
 #define RX6110SA_HID_DESC		"Real Time Clock"

/* Register layout */