Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 75: source "src/mainboard/supermicro/x11/variants/*/Kconfig"
Is there a need for this? Now there will be more files to maintain :/
This makes the Kconfig style way more readable by omitting "if" in every second line and moving variant-specific config to the variants folder. see https://review.coreboot.org/c/coreboot/+/35427
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 1: source "src/mainboard/supermicro/x11/variants/*/Kconfig.name"
Is there a need for this either? Now there will be a lot of very short files :/ […]
Well, I could live with putting all board names here but I *strongly* vote for using the Kconfig sourcing for the variant-specific stuff
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 174:
I'd suggest using tabs for this
Good idea, I'll change this