Attention is currently required from: Iru Cai. Hello Iru Cai,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/52089
to review the following change.
Change subject: mb/hp: Do not set EC SLPT on S5 for EliteBook laptops ......................................................................
mb/hp: Do not set EC SLPT on S5 for EliteBook laptops
This fixes https://ticket.coreboot.org/issues/304.
Tested on HP EliteBook 2560p, reboot and S3 resume work after this change.
Change-Id: I9b3ea737f85cc4045714263657bcdaac08f3a20d Signed-off-by: Iru Cai mytbk920423@gmail.com --- M src/mainboard/hp/folio_9480m/acpi/platform.asl M src/mainboard/hp/snb_ivb_laptops/acpi/platform.asl 2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/52089/1
diff --git a/src/mainboard/hp/folio_9480m/acpi/platform.asl b/src/mainboard/hp/folio_9480m/acpi/platform.asl index 8023ae8..d17f575 100644 --- a/src/mainboard/hp/folio_9480m/acpi/platform.asl +++ b/src/mainboard/hp/folio_9480m/acpi/platform.asl @@ -10,5 +10,8 @@
Method(_PTS,1) { - _SB.PCI0.LPCB.EC0.SLPT = Arg0 + If (Arg0 != 5) + { + _SB.PCI0.LPCB.EC0.SLPT = Arg0 + } } diff --git a/src/mainboard/hp/snb_ivb_laptops/acpi/platform.asl b/src/mainboard/hp/snb_ivb_laptops/acpi/platform.asl index 8023ae8..d17f575 100644 --- a/src/mainboard/hp/snb_ivb_laptops/acpi/platform.asl +++ b/src/mainboard/hp/snb_ivb_laptops/acpi/platform.asl @@ -10,5 +10,8 @@
Method(_PTS,1) { - _SB.PCI0.LPCB.EC0.SLPT = Arg0 + If (Arg0 != 5) + { + _SB.PCI0.LPCB.EC0.SLPT = Arg0 + } }