Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34522 )
Change subject: soc/intel/cannonlake: Set PCH Thermal Sensor configuration for S0ix ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34522/1/src/soc/intel/cannonlake/fi... File src/soc/intel/cannonlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/34522/1/src/soc/intel/cannonlake/fi... PS1, Line 36: #include <soc/intel/common/pch/include/thermal.h> intelpch/thermal.h would be nit