Attention is currently required from: Derek Huang, Brandon Breitenstein, Curtis Chen. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode ......................................................................
Patch Set 10:
(3 comments)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/57138/comment/26b9eb73_f258cdd7 PS10, Line 39: int Since this is being updated, can you please add a comment indicating what the return value is?
https://review.coreboot.org/c/coreboot/+/57138/comment/3a39a316_f1b746ed PS10, Line 40: int Can you please add comments indicating what the function does and also what the return value is?
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/57138/comment/4cc62834_345c0074 PS10, Line 1567: 1 << Port index I am curious why the return value is 1 << (port) and not port?
What happens if multiple ports are in alternate mode? It would be useful to return a bitmask in that case, but I think we should ensure corresponding bits are set for all ports that are in alternate mode and not just the first found port.