Attention is currently required from: Dtrain Hsu, Henry Sun, Paul Menzel, Shou-Chieh Hsu, Karthik Ramasubramanian.
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56248 )
Change subject: mb/google/dedede/var/cret: Enable/disable Touchscreen based on FW_CONFIG
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56248/comment/44559a86_d0b01137
PS3, Line 10: The Touchscreen settings are included GPIO settings and I2C bus settings.
Can you please rephrase this, as I do not fully understand the sentence?
Done
File src/mainboard/google/dedede/variants/cret/gpio.c:
https://review.coreboot.org/c/coreboot/+/56248/comment/de7609e5_a104246b
PS3, Line 103: // Audio codec
Please use C89 comment style for consistency.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice517c034e2dab93bb27e75dccf06d9a0936526b
Gerrit-Change-Number: 56248
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 13 Jul 2021 13:08:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment