Attention is currently required from: Felix Singer, Nico Huber, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53925 )
Change subject: soc/intel/skylake: Set proper defaults in chipset devicetree ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/skylake/chipset.cb:
https://review.coreboot.org/c/coreboot/+/53925/comment/47d24f5b_97d8a3d2 PS1, Line 63: n end # P2SB : device pci 1f.2 alias pmc on Yes I mean that hidden keyword. It does not hide things, but AFAICS it controls if a pci device that was hidden by the FSP before gets probed or not. That comment on pci_scan_hidden_device says: "This is useful when devices would like to be described in the devicetree.cb file [...] but the platform firmware hides the device (makes the device invisible to PCI enumeration) before PCI enumeration takes place." I'm unsure what exactly that means for the P2SB device, which does not have any children.
we shouldn't use `device pci` in such a case.
Mhh, you mean because it's not about the device actually, but the children (bus scanned or not)?