Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38994 )
Change subject: soc/intel/xeon_sp: Enable LPC generic IO decode range
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38994/1/src/soc/intel/xeon_sp/chip....
File src/soc/intel/xeon_sp/chip.h:
https://review.coreboot.org/c/coreboot/+/38994/1/src/soc/intel/xeon_sp/chip....
PS1, Line 89: uint32_t gen3_dec;
These ranges may or may not be defined in mainboard devicetree.cb file. […]
When they are not defined the values would be zero, which are the default values of these registers. So it's still fine if the common LPC function pch_enable_lpc() writes zero to them.
I also checked icelake and skylake's implementation they do not handle undefined case, either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38994
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I675489d3c66dad259e4101a17300176f6c0e8bd8
Gerrit-Change-Number: 38994
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 09:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment