Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42094 A new patchset has been uploaded, which is the parent change of this one.
https://review.coreboot.org/c/coreboot/+/41719/10/src/cpu/amd/pi/00730F01/up... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/cpu/amd/pi/00730F01/up... PS10, Line 24: u8 i;
I think this entire file should be unrelated. Hopefully it was included by accident.
Done. Removed the file which was added by accident. A new patch set is uploaded. https://review.coreboot.org/c/coreboot/+/42094/1
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/cpu.c File src/soc/amd/picasso/cpu.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/cpu.c@... PS10, Line 113: cpuid_eax(1)
move this cpuid_eax(1) call into the update_microcode function and don't pass it as parameter to the […]
Done. call this amd_update_microcode_from_cbfs() instead.