Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32724 )
Change subject: soc/intel/braswell/pmutil.c: Use GEN_PMCON1 for RTC status ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32724/1/src/soc/intel/braswell/pmutil.c File src/soc/intel/braswell/pmutil.c:
https://review.coreboot.org/#/c/32724/1/src/soc/intel/braswell/pmutil.c@367 PS1, Line 367: gen_pmcon1 = read32((u32 *)(PMC_BASE_ADDRESS + GEN_PMCON1));
This reads the current state that may already have been altered by […]
rtc_failure() is called by car_soc_post_console_init() and vbnv_cmos_failed(). For non-VBOOT platform I could verify that it works fine. I noticed that vbnv_cmos_failed() is used in VERSTAGE only. So this patch set will works in actual situations.
To be safe I will implement your suggestion.