1 Jul
2023
1 Jul
'23
7:43 p.m.
Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76212?usp=email )
Change subject: mb/google/rex/var/ovis: Enable LAN1 ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rex/variants/ovis/gpio.c:
https://review.coreboot.org/c/coreboot/+/76212/comment/ecca72e5_351557b3 : PS2, Line 405: GPP_D02 It is being set to 0 at both the places (bootblock and romstage). Is this intended?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76212?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb67cb8e6fc03e3ff14b1b3d8382322fd0b3aeff
Gerrit-Change-Number: 76212
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Comment-Date: Sat, 01 Jul 2023 17:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment