Attention is currently required from: Joel Linn.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81588?usp=email )
Change subject: superio/ite: Add function to disable 3VSBSW# signal
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/superio/ite/common/ite.h:
https://review.coreboot.org/c/coreboot/+/81588/comment/41df9210_a652630d :
PS1, Line 23: backwards compatibility
I'd rather say "for convenience" if we keep using them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81588?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8535176908ec39e9916774135e028cbc7c203474
Gerrit-Change-Number: 81588
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Linn
jl_coreboot@conductive.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Joel Linn
jl_coreboot@conductive.de
Gerrit-Comment-Date: Sat, 30 Mar 2024 13:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment