Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33198 )
Change subject: Makefile.inc: Add macro to link a file in all stages
......................................................................
Patch Set 6: Code-Review+1
Looks good, just the order of the parameters feels wrong.
Maybe that's just me, but... currently the condition comes
first:
somestage-$(CONFIG_SOMETHING) += somefile.c
Keeping that order would also help to emphasize the file
name, I think. Maybe we could even make that more literal,
e.g. `all_stages_if`:
$(call all_stages_if,$(CONFIG_SOMETHING),somefile.c)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955dd2dc22cb3cfc4fdf1198cfd32f56475f97c9
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Jun 2019 21:42:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment