Attention is currently required from: John Su. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52691 )
Change subject: mb/google/brya: Enable DPTF functionality for Brya ......................................................................
Patch Set 2:
(3 comments)
This change is ready for review.
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52691/comment/786a7b20_28b1007f PS2, Line 7: 28, : .tdp_pl2_override = 64 any reference document number for above PL1 and PL2 values?
https://review.coreboot.org/c/coreboot/+/52691/comment/51094fd2_8a1bf3c5 PS2, Line 20: tsr[0].desc" = ""Ambient"" : register "options.tsr[1].desc" = ""Battery"" : register "options.tsr[2].desc" = ""DDR"" : register "options.tsr[3].desc" = ""Skin"" I would able to find only 3 sensors as per schematics. Can you please confirm on above sensors on Brya ?
https://review.coreboot.org/c/coreboot/+/52691/comment/1c542932_b7e9f0ef PS2, Line 103: It seems all above policy setting values and sensors are the same as https://review.coreboot.org/c/coreboot/+/52020/9/src/mainboard/intel/adlrvp/... except PL1 and PL2 power values.