Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32189 )
Change subject: ACPI: Add RHSA and ANDD structures for DMAR table ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
Is there any user of this comming soon? or shall we go ahead and merge it just now?
https://review.coreboot.org/#/c/32189/3/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32189/3/src/arch/x86/acpi.c@616 PS3, Line 616: oid acpi_dmar_rhsa_fixup(unsigned long base, unsigned long current) : { : dmar_rhsa_entry_t *rhsa = (dmar_rhsa_entry_t *)base; : rhsa->length = current - base; : } : : void acpi_dmar_andd_fixup(unsigned long base, unsigned long current) : { : dmar_andd_entry_t *andd = (dmar_andd_entry_t *)base; : andd->length = current - base; : }
Updated.
Ack
https://review.coreboot.org/#/c/32189/4/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32189/4/src/arch/x86/acpi.c@577 PS4, Line 577: /* will be fixed up later */
deleted.
Ack
https://review.coreboot.org/#/c/32189/4/src/arch/x86/acpi.c@591 PS4, Line 591: /* will be fixed up later */
deleted.
Ack