Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55492
to review the following change.
Change subject: soc/intel/broadwell: Drop `config_t` typedef ......................................................................
soc/intel/broadwell: Drop `config_t` typedef
The typedef needlessly hides the actual type of the variables.
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: I58a58cd402ec679960f460e80b37ff2afb8e3974 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/chip.h M src/soc/intel/broadwell/gma.c 2 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/55492/1
diff --git a/src/soc/intel/broadwell/chip.h b/src/soc/intel/broadwell/chip.h index 045fdbc..8d72253 100644 --- a/src/soc/intel/broadwell/chip.h +++ b/src/soc/intel/broadwell/chip.h @@ -33,6 +33,4 @@ struct i915_gpu_controller_info gfx; };
-typedef struct soc_intel_broadwell_config config_t; - #endif diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c index 1e25502..dcbd1e3 100644 --- a/src/soc/intel/broadwell/gma.c +++ b/src/soc/intel/broadwell/gma.c @@ -284,7 +284,7 @@
static void gma_setup_panel(struct device *dev) { - config_t *conf = config_of(dev); + struct soc_intel_broadwell_config *conf = config_of(dev); const struct i915_gpu_panel_config *panel_cfg = &conf->panel_cfg; u32 reg32;
@@ -361,7 +361,7 @@ static int igd_get_cdclk_haswell(u32 *const cdsel, int *const inform_pc, struct device *const dev) { - const config_t *const conf = config_of(dev); + const struct soc_intel_broadwell_config *const conf = config_of(dev); int cdclk = conf->cdclk;
/* Check for ULX GT1 or GT2 */ @@ -396,7 +396,7 @@ struct device *const dev) { static const u32 cdsel_by_cdclk[] = { 0, 2, 0, 1, 3 }; - const config_t *const conf = config_of(dev); + const struct soc_intel_broadwell_config *const conf = config_of(dev); int cdclk = conf->cdclk;
/* Check for ULX */