Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37135 )
Change subject: Enable and fix compiler warnings
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/em100/+/37135/10/hexdump.c
File hexdump.c:
https://review.coreboot.org/c/em100/+/37135/10/hexdump.c@35
PS10, Line 35: int j
This could also be a size_t
Done
https://review.coreboot.org/c/em100/+/37135/10/spi.c
File spi.c:
https://review.coreboot.org/c/em100/+/37135/10/spi.c@82
PS10, Line 82: int read_spi_flash_page(struct em100 *em100, int addr, unsigned char *blk)
This no longer matches the declaration in em100.h […]
Done
--
To view, visit
https://review.coreboot.org/c/em100/+/37135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Idf8e6364a8ebba78b7c793f745048bffbc03e3ef
Gerrit-Change-Number: 37135
Gerrit-PatchSet: 10
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Nov 2019 00:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment