Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32642 )
Change subject: soc/amd/stoneyridge: Rename AcpiMmio blocks
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32642/1/src/soc/amd/stoneyridge/include/soc/...
File src/soc/amd/stoneyridge/include/soc/iomap.h:
https://review.coreboot.org/#/c/32642/1/src/soc/amd/stoneyridge/include/soc/...
PS1, Line 37: ACPIMMIO_SM_PCI_BASE
I can understand the name deriving from AMD_SB_ACPI_MMIO_ADDR, but I still believe that just MMIO....BASE would be better. There's no true ACPI involvement in most of the MMIO.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a69a6ecfc10f78b4860df05a77a061d2fc8be7d
Gerrit-Change-Number: 32642
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 19:17:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment