Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48003 )
Change subject: soc/intel/skl: correct OC pin skip value for disabled usb ports
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48003/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/48003/2/src/soc/intel/skylake/chip....
PS2, Line 160: if (config->usb3_ports[i].enable) {
: params->Usb3OverCurrentPin[i] = config->usb3_ports[i].ocpin;
: } else {
: params->Usb3OverCurrentPin[i] = OC_SKIP;
: }
while you're here, get rid of the extra curly braces here? not req'd for single-statement if/else
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41a8df3dce3712b4ab27c4e6e10160b2207406d1
Gerrit-Change-Number: 48003
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Nov 2020 21:44:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment