4 Sep
2019
4 Sep
'19
8:37 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34988 )
Change subject: mediatek/mt8183: Implement the dramc init setting ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/34988/2/src/soc/mediatek/mt8183/inc... PS2, Line 119: 0x2
IMHO, they do look like 4-bit register values. […]
Ping HungTe,
DQS_OEN_DELAY_2T and DQS_OEN_DELAY_0P5T were removed in patchset 11. Do you still think we need to name these magic numbers?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34988
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756ad37e78cd1384ee0eb97e5e18c5461d73bc7b
Gerrit-Change-Number: 34988
Gerrit-PatchSet: 12
Gerrit-Owner: huayang duan huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: SJ Huang sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: huayang duan huayangduan@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Sep 2019 06:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Comment-In-Reply-To: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-MessageType: comment