David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34795 )
Change subject: mb/google/hatch/var/kindred: Configure GPIOs for eMMC SKUs
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34795/4/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/c/coreboot/+/34795/4/src/mainboard/google/hatch/...
PS4, Line 141: if (sku_id == 2 || sku_id == 4 || sku_id == 21 || sku_id == 22) {
suspect code indent for conditional statements (8, 8)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f678a40555dbc841487811cc1f680b211a51a89
Gerrit-Change-Number: 34795
Gerrit-PatchSet: 5
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Aug 2019 03:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment