Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34282 )
Change subject: Revert "soc/intel/cannonlake: Add option to select FSP_CAR"
......................................................................
Patch Set 2:
Nico, the commit you're trying to revert has been in for a year. It was reviewed by Aaron, not by "Google". We are still people, not corporate shills.
Yeah, can't make everybody happy. If I say Google, that's bad,
if I say Martin, that's too personal, I get it.
Are you trying to tell me that Aaron's employment has nothing
to do with the fact that he didn't ask questions about the `if
MAINBOARD_HAS_CHROMEOS` in the patch?!?
If you disagree with the defaults, let's discuss it, but I don't think this revert is appropriate. The commit message and the threats against Subrata are also inappropriate.
Martin, seriously, what the fuck? Subrata is violating our Gerrit
guidelines all day and when I complain about it, then that is
inappropriate?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief7b85a9988d1a3f4a4639e9fd304959295958bd
Gerrit-Change-Number: 34282
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philip Prindeville
philipp@redfish-solutions.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 12 Jul 2019 15:55:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment