[coreboot-gerrit] Change in coreboot[master]: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33107 )

Change subject: [RFC]lib/coreboot_tables: Introduce BOOT_MEDIA_PARAMS2
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33107/4/src/commonlib/include/commo... 
File src/commonlib/include/commonlib/coreboot_tables.h:

https://review.coreboot.org/c/coreboot/+/33107/4/src/commonlib/include/commo... 
PS4, Line 494: 	uint64_t mmap_mmio_address;
> How does this relate to the FMAP-in-CBMEM thing you just uploaded? Most of this stuff is duplicated  […]

It's not just about APL. Other platforms like QEMU and SiFive Unleashed have memory mapped boot media, too.

I agree that most stuff isn't needed any more if FMAP is also present in memory.