Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48246 )
Change subject: soc/intel/common/block/acpi: Add soc MADT override
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48246/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/48246/7/src/soc/intel/common/block/...
PS7, Line 94: acpi_create_madt_lapics
This is a callback to the soc.
https://review.coreboot.org/c/coreboot/+/48246/7/src/soc/intel/common/block/...
PS7, Line 97: current += acpi_create_madt_ioapic((void *)current, 2, IO_APIC_ADDR, 0);
Based on Furquan's comment. Make this a weak callback to the soc to return a pointer to a madt table to be filled by this function. The default would remain the current setting. See soc_get_tss_table below as an example.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic818a634e4912d88ef93971deb4da5ab708c9020
Gerrit-Change-Number: 48246
Gerrit-PatchSet: 7
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 20:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment