[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Elaborate panel support for Kukui family boards.

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32511 )

Change subject: google/kukui: Elaborate panel support for Kukui family boards.
......................................................................

Patch Set 17:

I agree with Hung-te, this looks way more "elaborate" than necessary. Please don't over-design this from the start, just write the differentiation you need right now, you can always add more later. You don't need to have a structure full of function pointers, just call a function (e.g. mainboard_power_panel()), implement that in both panel_kukui.c and panel_krane.c and only link one of them in.

Do we expect that Kukui and Krane will always use a 100% distinct set of panels or will there eventually be some overlap? If so, maybe we want to compile all the actual panel info unconditionally and only put the <board>_panel_info arrays into the panel_<board>.c file (so the linker GC will drop unreferenced panel info structs).