Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36547 )
Change subject: security/vboot: Add config option to always enable the display ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig@... PS1, Line 170: config VBOOT_ALWAYS_ENABLE_DISPLAY
I think I'm following, but can you please explain why VBOOT_MUST_REQUEST_DISPLAY cannot be modified […]
I looked into a couple of options.
First clear the VBOOT_MUST_REQUEST_DISPLAY. This caused a hang in the display_init_required(). As far as I could see from the file history this is the desired behavior. So overriding it would require an additional config.
Second keeping the standard mechanism as is and control the display by populating the NV data with the display enabled. This would require quite some changes to the vboot code. So I didn't think it would work out as a valid path to get to a solution.
So this is why I ended up adding the additional Kconfig for this purpose. I have the impression that this indicates clear enough that by enabling the option the default VBOOT behavior is modified.
If you have a better suggestion this is of course welcome.
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig@... PS1, Line 171: bool "Force display enbled"
Where?
I am sorry, forgot to publish the edit.