Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48416 )
Change subject: mb/intel/adlrvp_p: Support VBT for LP4, LP5 and DDR5 SKUs ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
HI Furquan,
Can you please suggest something here.
This is how it was handled for drawman recently: https://crrev.com/i/3436383 and https://crrev.com/i/3439250
so we can't add this into cb makefile directly ?
You can do that, but you also have to add the .bin file here.
That is what the error is: "make[1]: *** No rule to make target '3rdparty/blobs/mainboard/intel/adlrvp_p/vbt_lp4.bin', needed by '/cb-build/coreboot-gerrit.0/chromeos/INTEL_ADLRVP_P/coreboot.pre'. Stop."
can we add like this to avoid the compilations issue
ifeq ($(CONFIG_INTEL_GMA_ADD_VBT),y) cbfs-files-y += vbt_lp4.bin vbt_lp4.bin-file := 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vbt_lp4.bin vbt_lp4.bin-type := raw vbt_lp4.bin-compression := lzma endif
https://review.coreboot.org/c/coreboot/+/48416/3/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48416/3/src/mainboard/intel/adlrvp/... PS3, Line 23: can we add like this
ifeq ($(CONFIG_INTEL_GMA_ADD_VBT),y) cbfs-files-y += vbt_lp4.bin vbt_lp4.bin-file := 3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vbt_lp4.bin vbt_lp4.bin-type := raw vbt_lp4.bin-compression := lzma endif