Dossym Nurmukhanov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41039 )
Change subject: libpayload/drivers/usb/xhci: Allow xHCI v1.2 in libpayload ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4: Code-Review+2
Patch Set 4:
24h, not 2.4h. Would have been nice to have the changes that might affect libpayload mentioned in the commit message.
Oh, yeah, sorry. The third +2 was implicit (adding it for reference now), and this patch was fairly trivial.
Let non-trivial patches sit in a review state for at least 24 hours before submission. Remember that there are coreboot developers in timezones all over the world, and everyone should have a chance to contribute. Trivial patches would be things like whitespace changes or spelling fixes, in general those that don’t impact the final binary output. The 24-hour period would start at submission, and would be restarted at any update which significantly changes any part of the patch. Patches can be ‘Fast-tracked’ and submitted in under 24 hours with the agreement of at least 3 +2 votes.
I think we should keep those fast track submissions for fixes to build breakage and the like. I'm also not sure if this qualifies as "trivial", given the example Julius dug up earlier about how the change to signal xHCI 1.1 support needed fixing in the code.
OTOH mistakes happen, this commit is easy to revert, and I'm not sure how big the impact really is, given that it requires the device to advertise xHCI 1.2 support first. Dossym, which platforms are affected by this?
This change was for Tiger Lake platforms