Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35554 )
Change subject: hatch: Create puff variant ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... PS1, Line 43: BOARD_ROMSIZE_KB_16384 I think that Puff reference is using 32MB
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... PS1, Line 2: ## Here as well.
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... PS1, Line 3: * Need to add in: Copyright 2019 Google LLC
You can view the corresponding Helios as an example.
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... PS1, Line 3: * Copyright info here as well
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... PS1, Line 3: * Here too.
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35554/1/src/mainboard/google/hatch/... PS1, Line 1: cannonlake
Should this be cometlake?
cometlake uses the cannonlake SOC code so this is correct.