Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34636 )
Change subject: mb/ocp/monolake: use VPD data to configure FSP UPD ......................................................................
Patch Set 16:
(6 comments)
https://review.coreboot.org/c/coreboot/+/34636/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34636/13//COMMIT_MSG@9 PS13, Line 9: Summary: : This patch adds: : * A framework to use VPD binary blob 2.0 data to configure : FSP UPD. : * A library to configure HyperThreading FSP UPD variable. :
Ack
Done
https://review.coreboot.org/c/coreboot/+/34636/1/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/34636/1/src/mainboard/ocp/monolake/... PS1, Line 112: board_configure_upd, (void *)UpdData) == VPD_FAIL)
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/34636/13/src/mainboard/ocp/monolake... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/34636/13/src/mainboard/ocp/monolake... PS13, Line 78: void *rw_vpd_addr = NULL; : size_t rw_vpd_size = -1; : UPD_DATA_REGION *UpdData = FspRtBuffer->Common.UpdDataRgnPtr; : : /* : * If RW_VPD VPD partition exists, search key/value pairs : * to see if there are relevant FSP UPD variable setting(s). : * If so, use such setting(s) to customize FSP behavior. : */ : if (CONFIG(VPD)) { : rw_vpd_size = get_vpd_size("RW_VPD", rw_vpd_addr); : if (rw_vpd_size == 0) : return; : : board_configure_upd(rw_vpd_addr, rw_vpd_size, UpdData); : printk(FSP_INFO_LEVEL, : "Found and Processed VPD binary blob in RW_VPD.\n"); : }
This patchset adds a framework and an example to use the framework. […]
Done
https://review.coreboot.org/c/coreboot/+/34636/15/src/mainboard/ocp/monolake... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/34636/15/src/mainboard/ocp/monolake... PS15, Line 75: == true
no need to write '== true' here since you're bool by itself.
Done
https://review.coreboot.org/c/coreboot/+/34636/13/src/mainboard/ocp/monolake... File src/mainboard/ocp/monolake/vpd_fsp.h:
https://review.coreboot.org/c/coreboot/+/34636/13/src/mainboard/ocp/monolake... PS13, Line 20: HyperThreading
In FSP UPD variable definition, CamelCase is used. […]
Done
https://review.coreboot.org/c/coreboot/+/34636/5/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/vpd_fsp.h:
https://review.coreboot.org/c/coreboot/+/34636/5/src/mainboard/ocp/monolake/... PS5, Line 4: Copyright (C) 2019 The coreboot Authors. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details.
Done
Done