Attention is currently required from: Martin Roth, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49880
to look at the new patch set (#2).
Change subject: [WIP] soc/intel: Remove duplicate call to acpi_wake_source() ......................................................................
[WIP] soc/intel: Remove duplicate call to acpi_wake_source()
With SOC_INTEL_COMMON_BLOCK_ACPI=y the call was made twice, possibly in the order:
common/block/acpi.c: acpi_wake_source() common/acpi_wake_source.c: acpi_wake_source()
In this order later call would reset pm1i and gpei in GNVS.
Remove the implementation in block/acpi.c and rename existing acpi_wake_source.c to block/acpi_wake_source.c.
Change-Id: I74fdae63111e3ea09000d888a918ebe70d711801 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/braswell/ramstage.c M src/soc/intel/common/Makefile.inc M src/soc/intel/common/block/acpi/Makefile.inc M src/soc/intel/common/block/acpi/acpi.c R src/soc/intel/common/block/acpi/acpi_wake_source.c R src/soc/intel/common/block/include/intelblocks/acpi_wake_source.h M src/soc/intel/denverton_ns/include/soc/nvs.h M src/soc/intel/skylake/acpi.c 8 files changed, 7 insertions(+), 86 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/49880/2