Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37268 )
Change subject: mb/google/octopus: test
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37268/3/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/lick/variant.c:
https://review.coreboot.org/c/coreboot/+/37268/3/src/mainboard/google/octopu...
PS3, Line 20: 0xFFFFFFFF
UINT32_MAX?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b1a79b022a0c698174dd08f3c11769a4fd6833c
Gerrit-Change-Number: 37268
Gerrit-PatchSet: 3
Gerrit-Owner: Regan Chang
regan.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Regan Chang
regan.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:44:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment